Closed nolan-veed closed 6 months ago
:robot: Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.
As mentioned in https://github.com/roc-streaming/dockerfiles/pull/16, please also update https://roc-streaming.org/toolkit/docs/development/continuous_integration.html
We forgot to add 24.04 to CI, done: https://github.com/roc-streaming/dockerfiles/commit/aecc5adfcfa5bb4f8608f479441b5a2aa64f0efd
(most images build all tags automatically, however for ubuntu each tag should be added manually, because we need to split ubuntu images into multiple CI jobs to avoid exceeding github limits for maximum job times)
We forgot to add 24.04 to CI...
Don't think I have perms to run the jobs again.
Oh wait... some other builds have failed as well. Something is unstable in develop.
There are two other failures:
Formatting. The problem appeared after we switched env-ubuntu:latest to 24.04. It uses more recent clang-format that disagrees with previous versions about formatting of one line. Unfortunately clang-format is not yet fully stabilized and it happens from time to time. For now, I just excluded the problematic file from auto-formatting: 9b159e8b76a18690e98af25f706a62034798a899
Pulseaudio build. Will take a look.
LGTM!
I've fixed pulseaudio build: e252b2bba4078492b6c15e22921635bd8d6931c9
It was caused by update to clang 17.
Why
For https://github.com/roc-streaming/roc-toolkit/issues/634
This adds the ci builds.
What
Testing
Should run on CI.