roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.02k stars 203 forks source link

NO_COLOR and FORCE_COLOR env vars support #666

Closed nolan-veed closed 6 months ago

nolan-veed commented 6 months ago

Why

For https://github.com/roc-streaming/roc-toolkit/issues/564

What

Created functions to check for NO_COLOR and FORCE_COLOR.
Created function to check if term supports color.
Used those methods in detect_color_support()
- Prefer NO_COLOR if both vars are available.
Updated man sources.
Generated man pages as well.

Testing

Tested NO_COLOR using ubuntu terminal.
Tested FORCE_COLOR by using ssh to localhost.

github-actions[bot] commented 6 months ago

:robot: Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

nolan-veed commented 6 months ago

Is there a better way to generate man pages?

nolan@nolan-veed:~/nolan-veed/roc-toolkit$ scons -Q --enable-werror --enable-doxygen --enable-sphinx docs
   SPHINX   docs/html/docs
   SPHINX   docs/man

Extension error:

Could not import extension sphinxemoji.sphinxemoji (exception: No module named 'sphinxemoji')
Extension error:

Could not import extension sphinxemoji.sphinxemoji (exception: No module named 'sphinxemoji')
scons: *** [build/docs/sphinx.html/commit] Error 2
scons: *** [build/docs/sphinx.man/commit] Error 2

nolan-veed commented 6 months ago

Is there a better way to generate man pages?

Never mind fixed it.

gavv commented 6 months ago

Thanks! Works great. Small follow-up commit: a09cc576aec79d26d442922a1100eb734e34e7da