Implement List pop_front() and pop_back()

roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.02k stars 203 forks source link

Closed gavv closed 4 months ago

gavv commented 6 months ago

core::List has push_front() and push_back().

It would be convenient to have two complementary methods:

void pop_front();
void pop_back();

New methods should be covered with tests.

as4456 commented 5 months ago

I am new to open source contributions and would like to pick this item if it hasn't been picked yet.

gavv commented 5 months ago

You're welcome, thanks!

spausum commented 4 months ago

If this issue is still open, I would love to take a crack at it.

gavv commented 4 months ago

@spausum Hi, thanks, it's assigned actually and there is a linked PR (see above).

gavv commented 4 months ago

Landed.