roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.02k stars 203 forks source link

IArena's NoopArena implementation #698

Closed nolan-veed closed 4 months ago

nolan-veed commented 4 months ago

Why

For #691

What

Created NoopArenaImpl class and instantiated NoopArena.
Used it in Array, Hashmap, dropping their constructors that supported no arena.
Updated other places.

Testing

Existing tests should suffice.

github-actions[bot] commented 4 months ago

:robot: Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

github-actions[bot] commented 4 months ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

gavv commented 4 months ago

Thanks for PR!

I've merged #652, so now NoopArena needs to implement new interface.
In Array in Hashmap, we can now use IArena& instead of IArena*.

gavv commented 4 months ago

CI failure is unrelated, you can ignore it.

github-actions[bot] commented 4 months ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

nolan-veed commented 4 months ago

CI failure is unrelated, you can ignore it.

Should be ready now. I had forgotten about point 2.

gavv commented 4 months ago

LGTM!

Small follow-up: ec82adab1ca2ea32ef904a82ff994c292219cf0c