Add ISink::flush() - Githubissues

roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.02k stars 203 forks source link

Add ISink::flush() #703

Open gavv opened 4 months ago

gavv commented 4 months ago

Implement explicit flushing of buffered samples from sink to file.

add virtual void flush() = 0 to sndio::ISink
add this method to all ISink implementations
for most implementations, flush() should be no-op, as they don't use buffering
for SoxSink, flush() should send buffered samples to disk
sndio::Pump should invoke flush() when it exits from run()

HTH24 commented 3 months ago

Hello gavv, I am really interested in this project as I have been podcasting for a couple of years. One question as this might be my first open source contribution: I write C++ in Xcode, and I do not see any main.cpp file. How would I make amendments to the code? Run it on the terminal using git after I have made changes to all .cpp and .hpp files? Is this the preferred way?

dmklepp commented 3 months ago

Hello, I'm new to this project. I will be attempting to fix this issue. Thank you!

gavv commented 2 months ago

Hello gavv, I am really interested in this project as I have been podcasting for a couple of years. One question as this might be my first open source contribution: I write C++ in Xcode, and I do not see any main.cpp file. How would I make amendments to the code? Run it on the terminal using git after I have made changes to all .cpp and .hpp files? Is this the preferred way?

@HTH24 Take a look at this page: https://roc-streaming.org/toolkit/docs/building/developer_cookbook.html

You need to use scons to build the project.

Hello, I'm new to this project. I will be attempting to fix this issue. Thank you!

@dmklepp Hi, thanks, I guess we should ask @HTH24 whether they still plan to work on this.

HTH24 commented 2 months ago

Thanks gave, I think I need more time to get familiar with the project. Let dmklepp take it.