roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.02k stars 203 forks source link

Splitting main() functionality #710

Open nolan-veed opened 3 months ago

nolan-veed commented 3 months ago

Why

For https://github.com/roc-streaming/roc-toolkit/issues/656

What

Testing

WIP

nolan-veed commented 3 months ago

@gavv Can I get some thoughts on approach?

github-actions[bot] commented 2 months ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

gavv commented 2 months ago

Thanks, will take a look in upcoming days!

I think the conflict is from this commit from here.

gavv commented 2 months ago

Also: d873794b234b49a32a4e19ad2be37354957d90bd

gavv commented 1 month ago

Hi, sorry for delay. I like the approach!

A few minor comments / thoughts:

gavv commented 1 month ago

If you'll decide to proceed with this PR, I think it's good idea to review & merge just one tool (e.g. roc_send) and then work on the rest, because we can find more pitfalls during review.