roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.02k stars 203 forks source link

Implement secure_random() #727

Closed lovvik closed 5 days ago

lovvik commented 3 weeks ago

as asked by issue #683

gavv commented 3 weeks ago

Thanks for PR!

Regarding my comment from matrix that you linked above: https://github.com/roc-streaming/roc-toolkit/issues/683#issuecomment-2148359306

I guess I was not very clear.

The idea is:

That's what I tried to say in that comment, we don't need two separate implementations of tests for secure_random, however we still need separate tests for fast_random and secure_random.

lovvik commented 3 weeks ago

oh...i really misinterpreted it all. It will be fixed.

github-actions[bot] commented 2 weeks ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.