implement safe backtrace print and exit upon SIGQUIT

roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.02k stars 203 forks source link

implement safe backtrace print and exit upon SIGQUIT #736

Closed MicJagger closed 1 week ago

MicJagger commented 1 week ago

https://github.com/roc-streaming/roc-toolkit/issues/566

github-actions[bot] commented 1 week ago

:robot: Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

gavv commented 1 week ago

Hi,

This patch is odd. signal_string() returns a string name of a signal, why on earth are you calling exit from it? Also you're not installing signal handler. _exit() doesn't take a signal as an argument (see man page). And all other signals are handled via die_gracefully(), not by calling exit.