Implement StringList pop_back()

roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.09k stars 213 forks source link

Implement StringList pop_back() #745

Closed jeshwanthreddy13 closed 4 months ago

jeshwanthreddy13 commented 4 months ago

Fixes #669

Implemented a new "void pop_back()" method.
Removes the last string from StringList.
Returns false if deallocation fails
Panics if StringList is empty.
Clears when last string is poped.

Test cases covered:

Size should be zero after removing last element from the list.
front and back have to point to same string when initial list with two strings is poped.
back_ should point to 'n-1' string after poping initial 'n' number of strings list.

github-actions[bot] commented 4 months ago

:robot: Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

gavv commented 4 months ago

Thank you!

gavv commented 4 months ago

Follow-up: use different string sizes in other tests too: 91581a05e5cfe6d89466afd4336a570dffe37cfb