Implemented explicit flushing of buffered samples from sink to file

roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.09k stars 213 forks source link

Closed jeshwanthreddy13 closed 3 months ago

jeshwanthreddy13 commented 4 months ago

Fixes #703

Added virtual ROC_ATTR_NODISCARD status::StatusCode flush()=0 pure virtual function in sndio::ISink.
Added this method to all ISink implementations.
Implementations that don't use buffereing are no-op.
For SoxSink, flush() sends the buffered samples to disk.
sndio::Pump invokes flush() when it exits from run().

github-actions[bot] commented 4 months ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

github-actions[bot] commented 3 months ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

gavv commented 3 months ago

Thank you!