Closed khansamad47 closed 8 months ago
@gavv can you please review
Hi, thanks for PR!
This wasn't a help wanted issue, so I didn't provide some details. No worries, here they are:
we should also allow to disable downloading roc, and use roc from system
we should also allow to disable downloading roc, and manually provide include and link dirs
when building roc, we need to use --build-3rdparty=all --enable-static --disable-shared, to get a static lib with all dependencies included, so that rt-tests will be self-contained
we need to build roc, then install it into prefix dir using "scons install" target, then use include and link dirs from the prefix dir
You can find examples of the above in roc-pulse and roc-vad repos:
https://github.com/roc-streaming/roc-pulse/blob/main/cmake/download_roc.cmake
https://github.com/roc-streaming/roc-pulse/blob/main/CMakeLists.txt
https://github.com/roc-streaming/roc-vad/blob/main/3rdparty/dependencies.cmake#L15
@gavv thank you for the review will fix
@gavv made the changes, I am downloading libtool via sudo apt do we need to build it locally as well? I see pulse is downloading and building it.
TODO: Test it a bit more Figure out the apt install dependencies, I just copied those from pulse for now.
Also, if you feel comfortable with github actions, it would be nice to update build.yaml to test three variants of build:
If you're not familiar with gh actions, no worries, I'll add this later.
Also, if you feel comfortable with github actions, it would be nice to update build.yaml to test three variants of build:
- default - download roc
- disable downloading roc, use roc installed system-wide
- disable downloading roc, use roc installed into custom dir with ROC_INCLUDE_DIR and ROC_LIB_DIR
If you're not familiar with gh actions, no worries, I'll add this later.
Done
@gavv ready for your review, let me know if you need anymore changes
Thanks you so much!
Small follow-up commit: 76b5c41e500da4085872b30a66ef459c273db985
A few more commits related to https://github.com/roc-streaming/rt-tests/issues/9:
And one more follow-up issue: https://github.com/roc-streaming/rt-tests/issues/12
Summary
fixes #9 task: "Download and build roc-toolkit instead of using system-wide installation. Allow to specify branch/ref "