roc-streaming / rt-tests

Real-time tests for Roc Toolkit.
Mozilla Public License 2.0
2 stars 6 forks source link

Adding cmake configuration to download roc-toolkit with branch provided via cmake variable #10

Closed khansamad47 closed 8 months ago

khansamad47 commented 10 months ago

Summary

fixes #9 task: "Download and build roc-toolkit instead of using system-wide installation. Allow to specify branch/ref "

khansamad47 commented 10 months ago

@gavv can you please review

gavv commented 10 months ago

Hi, thanks for PR!

This wasn't a help wanted issue, so I didn't provide some details. No worries, here they are:

gavv commented 10 months ago

You can find examples of the above in roc-pulse and roc-vad repos:

https://github.com/roc-streaming/roc-pulse/blob/main/cmake/download_roc.cmake

https://github.com/roc-streaming/roc-pulse/blob/main/CMakeLists.txt

https://github.com/roc-streaming/roc-vad/blob/main/3rdparty/dependencies.cmake#L15

khansamad47 commented 10 months ago

@gavv thank you for the review will fix

khansamad47 commented 9 months ago

@gavv made the changes, I am downloading libtool via sudo apt do we need to build it locally as well? I see pulse is downloading and building it.

TODO: Test it a bit more Figure out the apt install dependencies, I just copied those from pulse for now.

gavv commented 9 months ago

Also, if you feel comfortable with github actions, it would be nice to update build.yaml to test three variants of build:

If you're not familiar with gh actions, no worries, I'll add this later.

khansamad47 commented 9 months ago

Also, if you feel comfortable with github actions, it would be nice to update build.yaml to test three variants of build:

  • default - download roc
  • disable downloading roc, use roc installed system-wide
  • disable downloading roc, use roc installed into custom dir with ROC_INCLUDE_DIR and ROC_LIB_DIR

If you're not familiar with gh actions, no worries, I'll add this later.

Done

khansamad47 commented 8 months ago

@gavv ready for your review, let me know if you need anymore changes

gavv commented 8 months ago

Thanks you so much!

Small follow-up commit: 76b5c41e500da4085872b30a66ef459c273db985

gavv commented 8 months ago

A few more commits related to https://github.com/roc-streaming/rt-tests/issues/9:

gavv commented 8 months ago

And one more follow-up issue: https://github.com/roc-streaming/rt-tests/issues/12