search

roc-streaming / rt-tests

Real-time tests for Roc Toolkit.
Mozilla Public License 2.0
2 stars 6 forks source link

Basic Test for Command-line tools #6

Closed Mahn0318 closed 1 year ago

Mahn0318 commented 2 years ago

This is my first ever pull request ever. This was done for a school project and I based the code off the preexisting test_service_quality.cpp file.

gavv commented 1 year ago

Hi, thanks for PR.

I guess you misread the issue description. The issue is about creating tests for command-line tools, not the C library. For the C library, there is service quality test, there is no need to duplicate it.

The test should generate a WAV file, run roc-send to send it to network, and run roc-recv to receive it from network and write to a local file. Then the test should analyse the received file and compare it with the sent one.

To test cli tools, one would need to use a library like subprocess.

BTW also note that direct comparison of sent and received data is not correct. As mentioned in the issue, #1 has some hints on it. So unfortunately we can't add code from this PR to the service quality test neither.