search

roc230 / spymemcached

Automatically exported from code.google.com/p/spymemcached
0 stars 0 forks source link

MemcachedConnection handleInputQueue should poll #134

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What version of the product are you using? On what operating system?
Running the 2.3.1 client on RHEL. 

Tell me more...
MemcachedConnection handleInputQueue incurs unnecessary overhead when it
drains addedQueue by relying on remove() to throw NoSuchElementException
when the queue becomes empty. 
Poll should do the same thing without the exception handling, and performs
better on local benchmarks. 
Attached patch is for 2.3.1.

Thanks,
Paul.

Original issue reported on code.google.com by Paul.Bur...@gmail.com on 15 Apr 2010 at 1:31

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the patch. I will make sure it gets into the next version of 
Spymemcached.

Original comment by mikewie...@gmail.com on 16 Jul 2011 at 2:55

GoogleCodeExporter commented 9 years ago 
Fix committed.  Thanks!

http://review.couchbase.org/#change,8483

Original comment by ingen...@gmail.com on 28 Jul 2011 at 6:07

GoogleCodeExporter commented 9 years ago

Original comment by ingen...@gmail.com on 23 Aug 2011 at 3:37