search

roc230 / spymemcached

Automatically exported from code.google.com/p/spymemcached
0 stars 0 forks source link

Implementing read-only methods in MemcachedNodeROImpl #86

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

Can you consider implementing (via delegation) the read-only methods in the
MemcachedNodeROImpl class?  (such is isActive(), etc...)  We have a thin
wrapper around spymemcached that handles downed nodes in our memcached
cluster differently from the default way -- we basically never redistribute
and simply return "NullFuture"s for down'd nodes instead in order to
prevent stale data and we have our own custom logic for attempting to
reconnect later.  For now, we've updated MemcachedNodeROImpl.java to
delegate read-only operations instead of simply throwing
UnsupportedOperationException. 

Thanks

Original issue reported on code.google.com by greg...@gmail.com on 25 Aug 2009 at 12:57

GoogleCodeExporter commented 9 years ago 
I've attached a dead simple patch for this.  Any luck in getting something like 
this 
in?

Original comment by greg...@gmail.com on 7 Apr 2010 at 7:37

Attachments:

GoogleCodeExporter commented 9 years ago 
I can't get this patch to apply anywhere.  The easiest way to get this working 
is to commit it into a git repo from 
which I can fetch it or to use format-patch to get all your info into it.

I'm hoping to start using a public code review system that makes it easy for 
anyone to submit changes and walk 
them through a lifecycle.

Original comment by dsalli...@gmail.com on 7 Apr 2010 at 5:30

GoogleCodeExporter commented 9 years ago 
I just realized your patch was backwards and it does apply.  Any chance I can 
get you using git?  It would make 
it far easier to handle this stuff.

There's more information I'd like here before I do anything with it:

Your name and email (to not exclude you from the contributors list properly)
(usually) Upstream reference.

Then I can toss it into code review and we'll be good to go.

Original comment by dsalli...@gmail.com on 7 Apr 2010 at 5:43

GoogleCodeExporter commented 9 years ago 
Sure, here is my info:

Greg Kim - greggie@gmail.com

thanks
Greg

Original comment by greg...@gmail.com on 7 Apr 2010 at 6:01

GoogleCodeExporter commented 9 years ago 
Submitted for review:  https://review.northscale.com:8443/1287

Original comment by dsalli...@gmail.com on 7 Apr 2010 at 6:07

GoogleCodeExporter commented 9 years ago

Original comment by dsalli...@gmail.com on 7 Apr 2010 at 6:08

GoogleCodeExporter commented 9 years ago 
Pushed this through.  Thanks for your patience.  :)

Original comment by dsalli...@gmail.com on 7 Apr 2010 at 7:39