Update something - Githubissues

roccomuso / kickthemout

:bomb: Kick devices off your network by performing an ARP Spoof attack with Node.js.

MIT License

283 stars 30 forks source link

Closed realdennis closed 6 years ago

realdennis commented 6 years ago

Dependency a temporary arpjs (work around for node v10) (cause node_pcap and socketwatcher some namespace error in v10?) watch this and this
Remove broken badge (bitHound)
Add greenkeeper and remove nsp to keep the dependencies newest and safe
Add osx enviroment for travis
Some code style change for standard latest version auto fix

roccomuso commented 6 years ago

@realdennis does it works for you after the merge?

realdennis commented 6 years ago

Hey, I thought the root cause about Node v10 is the node_pcap(namespace error & depend old socketwatcher) but it fixed after merge 243

In this repo's(kickthemout) pull request, I just remove broken badge, update some dependencies and add Greenkeeper(but you need to open it).

Greenkeeper continuous check project's dependencies version and tell you CI result. (You can merge it when build pass.) Like this.

By the way, I thought we need to write more test case to keep a robust CI not just check coding style.

roccomuso commented 6 years ago

Yeah, PRs are welcome. I had no time to write tests.

Btw right now the inquirer selection is stuck when i run it with node 8. Are you having the same issue?

realdennis commented 6 years ago

I don't have this issue in Node v8, but I found that Inquirer.js doesn't support version under Node v6, I am sorry to aware it too late.