roccomuso / netcat

:computer: Netcat client and server modules written in pure Javascript for Node.js.
MIT License
419 stars 43 forks source link

Replace shortid with nanoid #8

Closed vrizo closed 7 years ago

vrizo commented 7 years ago

Hi!

Your package looks impressive! I think I've found a way how to improve it a little bit :) Please consider replacing shortid with nanoid. There are no significant changes for users, but there are some critical benefits:

What do you think about this, @roccomuso?

Thanks!

roccomuso commented 7 years ago

ok, i might consider the switch..

roccomuso commented 7 years ago

done, thanks. It would be cool if we also manage to make the tests pass on Mac.