search

roccomuso / netcat

:computer: Netcat client and server modules written in pure Javascript for Node.js.
MIT License
419 stars 43 forks source link

Replace shortid with nanoid #9

Closed vrizo closed 7 years ago

vrizo commented 7 years ago

Hi, @roccomuso !

Here is a fix of issue #8.

Please review and let me know if might be improved.

Thanks!

ai commented 6 years ago

Awesome! Should we release it?

roccomuso commented 6 years ago

@ai it's not a such a huge change worth a release. And please avoid spamming like that.

ai commented 6 years ago

Sorry if I bother you.

In my open source projects (Autoprefixer, PostCSS and Browserslist) I release changes imminently after accepting PR.

There is no rule about release size. Secondly it is even opposite. In my open source experience, users prefer small releases, since updating to small release is safer and more predictable.

But it is only my experience. Of course, in your case maybe you have good reasons to keep releases big.

P. S. I am also shortid maintenair, so I don't need to shortid > nanoid migration itself 😉