search

roccomuso / node-webhooks

:arrow_right_hook: Node.js module to create and trigger your own webHooks.
190 stars 47 forks source link

added custom headers on trigger #1

Closed alopezvillaverde closed 8 years ago

alopezvillaverde commented 8 years ago

Including custom headers on trigger webHook if provided

roccomuso commented 8 years ago

Great. Let me review it and then I'll merge. :) I was also thinking about a complete module rewritten. This module was written in a rush. Would not be bad to better optimize the code.

roccomuso commented 8 years ago

@alopezvillaverde thank you. Publishing soon the new version on NPM.

roccomuso commented 8 years ago

@alopezvillaverde I Just want to let you know that Object.assign https://github.com/roccomuso/node-webhooks/blob/master/index.js#L91 is not available for node v0.12 and older. That's why this build failed: https://travis-ci.org/roccomuso/node-webhooks/jobs/156587904 we should find an alternative to be able to support older versions of node.

alopezvillaverde commented 8 years ago

@roccomuso I saw the lodash merge change. Perfect!