search

roccomuso / node-webhooks

:arrow_right_hook: Node.js module to create and trigger your own webHooks.
190 stars 47 forks source link

Url parameter interpolation feature #22

Open dankelleher opened 5 years ago

dankelleher commented 5 years ago

Allows you to define webhooks like this:

webHooks.add('hook', URI + '/:id/abc')

and trigger like this:

webHooks.trigger('hook', {}, {}, { id: '123' })
coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 91.86% when pulling aaf82a132ea3e8caa24ecf689f3bef272b12e605 on civicteam:feature/url-parameter-interpolation into baf14131778e177657471d298d627f9ca978d929 on roccomuso:master.

roccomuso commented 5 years ago

This will be a breaking change for current api. And also .trigger functions is getting too much params. We should consider a better approach

dankelleher commented 5 years ago

I don't think it breaks the current API, does it? Unless you have colons in your URL. Then it might break alright.

How about a trigger() function that accepts (name, options) where options is an object of the form {body, headers, parameters}. This is roughly similar to how common http client libraries work, which is effectively what trigger() is anyway.

roccomuso commented 5 years ago

it would be better, yep.