rocdev-foundation / rocdev

RocDev site
MIT License
18 stars 7 forks source link

Vagrantfile permissions #68

Open danieljaouen opened 6 years ago

danieljaouen commented 6 years ago

The current Vagrantfile mounts /vagrant with owner and group vagrant. However, asdf (as well as other .bashrc customizations) is installed to the ubuntu user. It therefore seems to be intended that /vagrant/precheck and /vagrant/app/app_up are run as the ubuntu user. However, due to the Vagrant permissions, some steps (including building the nodejs assets) cannot write to the /vagrant folder. I've fixed this in my fork by mounting /vagrant with owner and group ubuntu. However, I'm not sure if this will break things on your end, so I leave it up to you to review the pull request before merging.

Actual Behavior

/vagrant/precheck fails to build nodejs assets.

Expected Behavior

/vagrant/precheck successfully builds nodejs assets.

Steps to Reproduce

  1. Run /vagrant/precheck as ubuntu user.
  2. Wait for nodejs build error.

Relevant Specifications (OS, Hardware, etc.)