roceys / minimalist

Automatically exported from code.google.com/p/minimalist
0 stars 0 forks source link

Hide new look popup and hide bottom ads not working on some accounts #18

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Please describe the feature or enhancement in as much detail as possible:
Hide the new ads in Gmail, see attachment.
The following code can do this:

/*
hide the new ads in Gmail
*/
div.nH div.nH.PS {
    display: none !important;
}

Original issue reported on code.google.com by jief...@gmail.com on 13 Nov 2011 at 4:29

Attachments:

GoogleCodeExporter commented 8 years ago
Does Main > Ads > Hide bottom ads not work for you?

Original comment by anst...@gmail.com on 13 Nov 2011 at 6:14

GoogleCodeExporter commented 8 years ago
No, it does not work.
"Hide New Look popup" does not work neither.

The following code works:

/*
hide the new ads in Gmail
*/
div.nH div.nH.PS {
    display: none !important;
}

/*
hide new look feedback
*/
div.nH.oy8Mbf div.w-asK.w-atd {
    display: none !important;
}

Original comment by jief...@gmail.com on 13 Nov 2011 at 7:44

GoogleCodeExporter commented 8 years ago
One of my other accounts uses the same selector framework as yours. Changes:

/* Hide New Look popup*/
.GcwpPb-bEO5kc,
.w-atd {
    display: none;
}

/* Hide bottom ads */
.z0DeRc,
.PS {
    display: none;
}

(Classes in Gmail are often unique so I've narrowed yours down. They don't like 
using IDs for elements that aren't targeted by JS)

Can you manually put this new CSS in your MinGmail module and make sure it 
works without an unintended side-effects?

Original comment by anst...@gmail.com on 13 Nov 2011 at 4:16

GoogleCodeExporter commented 8 years ago
It works fine.

Original comment by jief...@gmail.com on 13 Nov 2011 at 4:37

GoogleCodeExporter commented 8 years ago
Awesome thanks, changes will be in 0.4.9. I'll give you credit for both in the 
changelog.

Original comment by anst...@gmail.com on 13 Nov 2011 at 4:44

GoogleCodeExporter commented 8 years ago
I'm not sure if this is related to this issue or not.  But I've got minimalist 
for gmail, reporting version 2.0.0.  The General -> Hide New Look popup has no 
noticeable effect.

Original comment by giantpune@gmail.com on 16 Nov 2011 at 2:03

GoogleCodeExporter commented 8 years ago
Yep, Google is changing some class names and I was on the later end of the 
rollout. It will be fixed tonight

Original comment by anst...@gmail.com on 16 Nov 2011 at 2:12

GoogleCodeExporter commented 8 years ago
Fixed in 0.5.2. Please update and confirm.

Original comment by anst...@gmail.com on 16 Nov 2011 at 5:54

GoogleCodeExporter commented 8 years ago
OK, well done!

Original comment by jief...@gmail.com on 16 Nov 2011 at 6:08

GoogleCodeExporter commented 8 years ago

Original comment by anst...@gmail.com on 16 Nov 2011 at 6:12