roceys / minimalist

Automatically exported from code.google.com/p/minimalist
0 stars 0 forks source link

Gmail > Main > Hide Sidebar does not work in split pane mode #20

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What is the problem? Describe completely:
Gmail > Main > Hide Sidebar does not work in split pane mode, the people widget 
is still there.

Remove ".iY" in the CSS code ".iY .Bu:not(:first-child)" works.

Minimalist version   - 0.4.8
Relevant core module - Minimalist for Gmail
Chrome version       -
Operating System     -
Language             -
Google Apps user?    -
Other extensions     -

Please provide any additional information below and attach screenshots if
relevant.

Original issue reported on code.google.com by jief...@gmail.com on 13 Nov 2011 at 5:06

GoogleCodeExporter commented 8 years ago
Thanks for the report and the fix. It'll be in 0.4.9.

Original comment by anst...@gmail.com on 14 Nov 2011 at 12:11

GoogleCodeExporter commented 8 years ago
Fixed in 0.5.2. Please update and confirm.

Original comment by anst...@gmail.com on 16 Nov 2011 at 5:54

GoogleCodeExporter commented 8 years ago
OK, well done!

Original comment by jief...@gmail.com on 16 Nov 2011 at 6:11

GoogleCodeExporter commented 8 years ago

Original comment by anst...@gmail.com on 16 Nov 2011 at 6:16

GoogleCodeExporter commented 8 years ago
Per my email conversation with Ansel, I am adding a comment that this appears 
to be broken again -- Minimalist for Everything v0.5.2 with Gmail module 
v2.0.2.  Under the "Main" category, "Hide Sidebar Ads" and "Hide Sidebar" are 
both turned on.

See attached screenshot.  Something else to note, is that it's not always a 
blank area (white space) that is shown, but sometimes ads are shown as well -- 
as if those 2 settings (sometimes) aren't having an effect at all.  In fact, 
while writing this comment -- I went back to my Gmail tab, hit F5, and now the 
ads are back.  Previously they went away after clicking on a few different 
messages; but now they won't go away, even after a dozen or more message 
changes.

I've tried this on 2 different computers -- same result.

Original comment by marc.pe...@gmail.com on 17 Nov 2011 at 6:03

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by anst...@gmail.com on 17 Nov 2011 at 6:09

GoogleCodeExporter commented 8 years ago
Hey marc, just pushed 0.5.3. Can you make sure you're updated and let me know 
if there is any change?

Original comment by anst...@gmail.com on 19 Nov 2011 at 2:57

GoogleCodeExporter commented 8 years ago
Hi Ansel,

Thanks for continuing to be responsive.  First of all, it definitely seems to 
be working now.  However, as I'll explain, I don't think it was anything new in 
version 0.5.3 that fixed it (maybe, but I'm not sure):

I really thought I had previously tested this on 2 different machines.  
However, in my haste I wonder if on the 2nd machine (my desktop computer) it 
might have been the Minimalist for Gmail extension rather than Minimalist for 
Everything with the Gmail module.

I got it to work right away on my desktop computer.  But on my laptop (where I 
originally discovered the issue), even with version 0.5.3, it wasn't working. I 
tried a bunch of things, disabling extensions, etc..  But on a hunch I tried 
something with the Minimalist for Everything options.  I had an old "undefined" 
module in there, from when I originally installed (and didn't really use) Min 
for Everything when it was still "Alpha."  I deleted that module, and...  
voila!  It works now  :-)

Original comment by marc.pe...@gmail.com on 19 Nov 2011 at 4:25

GoogleCodeExporter commented 8 years ago
Thanks Marc! Yes the undefined module breaks the extension. That was only an 
issue for about a day a while back but if you got the extension that day you 
have to delete it manually. Thanks for the update.

Original comment by anst...@gmail.com on 19 Nov 2011 at 4:28