search

roceys / minimalist

Automatically exported from code.google.com/p/minimalist
0 stars 0 forks source link

Hide Google bar and sub-features not compatible with accounts not signed up for G+ #45

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What is the problem?

Minimalist version   - v. 2.0.4
Chrome version       - v.15.0.874.121
Operating System     - Mac OSX Snow Leopard
Language             - English

I have the hide Google Bar activated. However, when i click to show it, the 
buttons ("my name" and Google Settings) on the top right corner doesn't work, i 
click on them and they do nothing.

Original issue reported on code.google.com by chrmeseg...@gmail.com on 20 Nov 2011 at 7:01

Attachments:

GoogleCodeExporter commented 8 years ago 
Can you go to the Minimalist for Everything About page and ensure that you are 
running 0.5.6?

Original comment by anst...@gmail.com on 20 Nov 2011 at 7:03

GoogleCodeExporter commented 8 years ago 
Yes, It is the 0.5.6 (I have installed it today)

Original comment by chrmeseg...@gmail.com on 20 Nov 2011 at 7:08

GoogleCodeExporter commented 8 years ago 
Okay thanks.

1) Right-click one of the buttons that isn't working
2) Select Inspect Element
3) Make the pane with code that pops up as big as you can and take a screenshot 
so I can see what element is covering up the buttons.

Original comment by anst...@gmail.com on 20 Nov 2011 at 7:23

GoogleCodeExporter commented 8 years ago 
Here it is, I hope it's big enough for you to see it
Thanks

Original comment by chrmeseg...@gmail.com on 20 Nov 2011 at 8:09

Attachments:

GoogleCodeExporter commented 8 years ago 
Well that's unexpected. Nothing is covering up the buttons. You appear to have 
a different version of the Google Bar than me. I don't have the arrow next to 
my name.

1) Does the settings button work?
2) Are you hiding the user photo?

Original comment by anst...@gmail.com on 20 Nov 2011 at 8:17

GoogleCodeExporter commented 8 years ago 
The settings button does not work either.
I dont have a user photo, so i guess that's why it doesn't appear

Original comment by chrmeseg...@gmail.com on 20 Nov 2011 at 8:29

GoogleCodeExporter commented 8 years ago 
Oh interesting I didn't know that's how it was handled. So if you disable Hide 
Google Bar, both the name and settings function as expected?

Original comment by anst...@gmail.com on 20 Nov 2011 at 8:31

GoogleCodeExporter commented 8 years ago 
Yes, if i disable Hide Google Bar, the name and settings work correctly

Original comment by chrmeseg...@gmail.com on 20 Nov 2011 at 8:35

GoogleCodeExporter commented 8 years ago 
Okay thanks for troubleshooting this with me. I'll do some further testing with 
this feature before the next release and see if I can figure out what's going 
on.

Original comment by anst...@gmail.com on 20 Nov 2011 at 8:37

GoogleCodeExporter commented 8 years ago 
Thanks for your help!
If it helps, when i click the button (either my name or the settings) the 
browser tab "makes" as if it was loading the webpage but then nothing happens

Original comment by chrmeseg...@gmail.com on 20 Nov 2011 at 8:41

GoogleCodeExporter commented 8 years ago 
I'm also having a problem that I believe may be related to this issue. 
Similarly, I do not have a user photo or Google+ account. When I enable Hide 
Google Bar, I cannot see the main mail pane or chat after Gmail reloads 
(screenshot attached). I can also confirm that clicking on my name or the gear 
for the settings causes the tab to briefly load, but nothing happens.

I'm running
Minimalist 0.5.7
Chrome 15.0.874.121
Mac OS X 10.6.8

Thanks for your work on the great extension!

Original comment by jbaran...@gmail.com on 21 Nov 2011 at 7:18

Attachments:

GoogleCodeExporter commented 8 years ago 
Wow! I didn't even know you could take screenshots in TIFF...

I believe we have narrowed down the root cause of the bug: No G+ Account.

I think I've found the technical reason as well: polluted global namespace. 
There are a couple conflicting variable names between the Gbar without G+ and 
the hide Google Bar feature. I will resolve these conflicts in the next version.

Original comment by anst...@gmail.com on 21 Nov 2011 at 7:26

GoogleCodeExporter commented 8 years ago 
OK. thanks a lot for worrying so much and trying to improve it!

Original comment by chrmeseg...@gmail.com on 21 Nov 2011 at 7:33

GoogleCodeExporter commented 8 years ago 
Just to clarify, it turns out that 'Hide Sidebar' is what's making the main 
area disappear as shown in my screenshot.  The 'Hide Google Bar' behavior is 
consistent with what the original bug report states.

And yeah... in OS X, it seems that the default screenshot format is TIFF

Original comment by jbaran...@gmail.com on 22 Nov 2011 at 12:36

GoogleCodeExporter commented 8 years ago 
lol why would anyone ever need to have lossless screenshots? Even if they did 
PNG is SO much smaller.

Anyway, thanks for following up, I'll check out Hide Sidebar as well

Original comment by anst...@gmail.com on 22 Nov 2011 at 1:40

GoogleCodeExporter commented 8 years ago 
I believe I have resolved the JS namespace conflict. Please ensure that you are 
on 0.5.8 and let me know if the Google Bar links are working for you again.

Original comment by anst...@gmail.com on 22 Nov 2011 at 7:07

GoogleCodeExporter commented 8 years ago 
Issue 58 has been merged into this issue.

Original comment by anst...@gmail.com on 22 Nov 2011 at 7:09

GoogleCodeExporter commented 8 years ago 
Fixed! Thanks for the hard work!

Original comment by jbaran...@gmail.com on 22 Nov 2011 at 2:59

GoogleCodeExporter commented 8 years ago

Original comment by anst...@gmail.com on 22 Nov 2011 at 5:08