search

rochars / wavefile

Create, read and write wav files according to the specs. :star: :notes: :heart:
MIT License
228 stars 48 forks source link

`samples` does not exist #1

Closed ismay closed 6 years ago

ismay commented 6 years ago

It seems that samples does not exist as documented in the readme:

// array of numbers
console.log(wav.samples);

instead, it's available under samples_, and the unit tests seem to only test for the samples_ property as well. Is this an oversight? Should samples not be available under samples and not samples_?

rochars commented 6 years ago

"samples" was renamed to "samples" and "bitDepth" was renamed to "bitDepth". Thanks.

ismay commented 6 years ago

Cool, thanks for the quick fix! 👍🎉