search

rochefort-lab / fissa

A Python toolbox for Fast Image Signal Separation Analysis, designed for Calcium Imaging data.
GNU General Public License v3.0
30 stars 28 forks source link

BUG: De-synchronisation in shape #244

Closed scottclowe closed 3 years ago

scottclowe commented 3 years ago

If the images or raw attributes are changed after initialising the array, the nTrials and nCell properties can become de-synced with the actual number of images and ROIs. c.f. pakanlab@4f136e7

We stop relying on these properties and dynamically get the values from the current size of result/raw/images.

codecov[bot] commented 3 years ago

Codecov Report

Merging #244 (2f4e287) into master (ab895c3) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   93.74%   93.81%   +0.07%     
==========================================
  Files           8        8              
  Lines        1071     1084      +13     
  Branches      248      251       +3     
==========================================
+ Hits         1004     1017      +13     
  Misses         34       34              
  Partials       33       33
Flag Coverage Δ
nbsmoke 59.96% <83.33%> (+0.20%) :arrow_up:
unittests 93.54% <100.00%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fissa/core.py 96.51% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab895c3...2f4e287. Read the comment docs.