rochefort-lab / fissa

A Python toolbox for Fast Image Signal Separation Analysis, designed for Calcium Imaging data.
GNU General Public License v3.0
30 stars 28 forks source link

ENH: Compare analysis params when loading from cache #245

Closed scottclowe closed 3 years ago

scottclowe commented 3 years ago

The load method now refuses to load if the analysis parameters in the cache do not match the parameters of the Experiment instance.

The method can be refined in future efforts, but I think it is advantageous to include as-is and then improve from there.

codecov[bot] commented 3 years ago

Codecov Report

Merging #245 (4643ff4) into master (862a251) will increase coverage by 0.25%. The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   93.88%   94.13%   +0.25%     
==========================================
  Files           8        8              
  Lines        1095     1176      +81     
  Branches      254      288      +34     
==========================================
+ Hits         1028     1107      +79     
- Misses         34       35       +1     
- Partials       33       34       +1     
Flag Coverage Δ
nbsmoke 60.28% <54.44%> (-0.36%) :arrow_down:
unittests 93.87% <97.77%> (+0.27%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fissa/core.py 96.72% <97.77%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 862a251...4643ff4. Read the comment docs.