rochefort-lab / fissa

A Python toolbox for Fast Image Signal Separation Analysis, designed for Calcium Imaging data.
GNU General Public License v3.0
30 stars 28 forks source link

Add cap to numpy and shapely version support, fix tests, upgrade precommit #291

Closed scottclowe closed 2 months ago

scottclowe commented 2 months ago

Closes #285. Closes #290.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.47%. Comparing base (8cf6a17) to head (1641e43). Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
fissa/readimagejrois.py 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (8cf6a17) and HEAD (1641e43). Click for more details.

HEAD has 149 uploads less than BASE | Flag | BASE (8cf6a17) | HEAD (1641e43) | |------|------|------| |unittests|82|0| |nbsmoke|67|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #291 +/- ## =========================================== - Coverage 94.08% 83.47% -10.62% =========================================== Files 8 8 Lines 1217 1198 -19 Branches 313 304 -9 =========================================== - Hits 1145 1000 -145 - Misses 36 162 +126 Partials 36 36 ``` | [Flag](https://app.codecov.io/gh/rochefort-lab/fissa/pull/291/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rochefort-lab) | Coverage Δ | | |---|---|---| | [nbsmoke](https://app.codecov.io/gh/rochefort-lab/fissa/pull/291/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rochefort-lab) | `?` | | | [unittests](https://app.codecov.io/gh/rochefort-lab/fissa/pull/291/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rochefort-lab) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rochefort-lab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.