rochford77 / ReplayAnalyzerRL

Wrapper for CarBall .replay Parser (Rocket League)
Apache License 2.0
2 stars 0 forks source link

handling key errors in parsing json is not handled properly #7

Closed rochford77 closed 5 years ago

rochford77 commented 5 years ago

.get(key, default) is the correct way to get keys, handle key errors rather than checking to see if they exist

rochford77 commented 5 years ago

still getting the nodes by key the old way but moved from if-else to try-catch for speed, readability, and so I don't look like a total dofus if an actual python dev sees this.