rocicorp / fractional-indexing

Fractional Indexing in JavaScript
https://npmjs.com/fractional-indexing
Creative Commons Zero v1.0 Universal
316 stars 23 forks source link

I ported this repo to the Kotlin language #17

Closed darvelo closed 1 year ago

darvelo commented 1 year ago

Hey, thank you for this great work.

I took some time to port this code over to Kotlin and used the same license. It can be found at https://github.com/darvelo/fractional-indexing-kotlin with acknowledgements to this repo. Please let me know if it's okay to make this port public.

All the tests were ported as well and they all pass.

aboodman commented 1 year ago

Of course, please do. Also if the port is meant to be bytewise compatible with the js impl you may want to note that in the readme.

darvelo commented 1 year ago

Great, thanks. Not sure what you mean by bytewise compatible. I had to make a few minor changes to fit the Kotlin language and standard library and I'm not entirely sure the port is 100% the same, only that all the existing tests pass. 😄

aboodman commented 1 year ago

I mean if it is the intent that this will generate same strings as js port for any given input.

On Wed, Jul 5, 2023 at 7:24 AM David Arvelo @.***> wrote:

Great, thanks. Not sure what you mean by bytewise compatible. I had to make a few minor changes to fit the Kotlin language and I'm not entirely sure the port is 100% the same, only that all the existing tests pass. 😄

— Reply to this email directly, view it on GitHub https://github.com/rocicorp/fractional-indexing/issues/17#issuecomment-1621868363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATUBFSEYBSA7WBUHVX3I3XOV2IVANCNFSM6AAAAAAZ65LUKY . You are receiving this because you commented.Message ID: @.***>

-- a (phone)

darvelo commented 1 year ago

All right, I added a note to that effect (meant to be 100%, but no guarantees).

Thanks again for this work!

aboodman commented 1 year ago

Cool, I added a link here: https://github.com/rocicorp/fractional-indexing#other-languages

darvelo commented 1 year ago

Awesome, thanks 🎉