rocicorp / repc

The canonical Replicache client, implemented in Rust.
Other
31 stars 7 forks source link

Treat transaction args as opaque data #151

Open aboodman opened 4 years ago

aboodman commented 4 years ago

Currently transaction arguments are decoded in both repc and replicache-sdk-js in various locations. This is both expensive and also prevents us from easily doing useful sanity checks.

aboodman commented 4 years ago

See https://github.com/rocicorp/repc/pull/153/commits/9e73ae592d2980a7c9f360fc1d9625b84b891564 for previous sanity check that should be re-instated with this bug.

aboodman commented 4 years ago

See #139

phritz commented 4 years ago

args in opentransaciton become a string https://github.com/rocicorp/repc/blob/a5ee7e5caeebdd41205046356853b22dfd0aed56/src/embed/types.rs#L13

phritz commented 4 years ago

this forces one of three choices:

  1. move to something not json at the boundaries with customers (prolly not tenable rn)
  2. base64 encode values
  3. or use strings
phritz commented 4 years ago

heh: