search

rocicorp / repc

The canonical Replicache client, implemented in Rust.
Other
30 stars 7 forks source link

Experimenting with required flatbuffer fields #246

Closed arv closed 4 years ago

arv commented 4 years ago

This marks fields in leaf.fbs as required

That has the effect that the API gets a little bit cleaner.

arv commented 4 years ago

This should be safe because once marked as required there is no way to leave out the fields.

What about reading data with missing fields? We already asserted that we didn't write empty key/val entries

WDYT?

aboodman commented 4 years ago

Let's talk about this in Slack. Fritz and I discussed this previously and decided it was a bad idea.

On Wed, Oct 28, 2020 at 4:08 PM Erik Arvidsson notifications@github.com wrote:

This should be safe because once marked as required there is no way to leave out the fields.

What about reading data with missing fields? We already asserted that we didn't write empty key/val entries

WDYT?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rocicorp/repc/pull/246#issuecomment-718312311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATUBF4MKQ2BGS6WNAOOJTSNDFBRANCNFSM4TDDNALQ .