Change beginSync to pull/push

rocicorp / repc

The canonical Replicache client, implemented in Rust.

Other

31 stars 7 forks source link

Change beginSync to pull/push #294

Closed arv closed 3 years ago

arv commented 3 years ago

Tear apart beginSync to do push and beginPull. maybeEndSync becomes maybeEndPull.

aboodman commented 3 years ago

It's ending up so elegant and useful that push and pull are separate. This was a real nice design choice @phritz .

phritz commented 3 years ago

@arv i don't think any of my review comments are blockers so might make sense for you to merge this and then follow up to address any review comments that require code changes. that way i can get started on some of the parallelizable stuff.

arv commented 3 years ago

landing and making changes in a new PR