search

rocicorp / repc

The canonical Replicache client, implemented in Rust.
Other
30 stars 7 forks source link

tiny diffsync followups #326

Closed phritz closed 3 years ago

phritz commented 3 years ago

progress towards https://github.com/rocicorp/repc/issues/290

phritz commented 3 years ago

I always imagined we would include the app_version/schemaVersion in push too. It seems important for the server to know what version the client is at in a push request too.

Recall for pull that pull_version indicates the version of the protocol the client is using which is hard-coded in repc, and schema_version indicates what kind of client view the app understands and is set by the customer's code. For push, we already have push_version to indicate the version of the protocol repc is using. I think what you are asking is that we include a schema_version in push as well, that would indicate... what? The schema of the mutator args? That makes sense I guess but want to be sure what you are suggesting. I had imagined new versions of mutators just get new names (eg., DO_FOO_v2).

arv commented 3 years ago

I have been arguing for DO_FOO_v2 in the past. Lets just stick with that story until costumers keep shooting themselves in the foot.

I think what you are asking is that we include a schema_version in push as well, that would indicate... what? The schema of the mutator args?

Correct

phritz commented 3 years ago

Well, too late :) https://github.com/rocicorp/repc/pull/327