search

rocicorp / repc

The canonical Replicache client, implemented in Rust.
Other
31 stars 7 forks source link

startAt should use secondary key index scans #344

Closed arv closed 3 years ago

arv commented 3 years ago

The fact that startAt uses the primary key for index scans is a bug. Can you mark it as such then fix it subsequently?

_Originally posted by @aboodman in https://github.com/rocicorp/replicache/pull/365#discussion_r627070530_

arv commented 3 years ago

This seems to work as expected to me. @aboodman please verify that repc is doing the right thing. Will test js side next.

arv commented 3 years ago

There is also a JS test at https://github.com/rocicorp/replicache/blob/13ca0cabd63cd2299fb082f94528241f1b99dd5e/src/replicache.test.ts#L1665