search

rocicorp / repc

The canonical Replicache client, implemented in Rust.
Other
31 stars 7 forks source link

Node::try_from. #348

Closed sayrer closed 2 years ago

sayrer commented 3 years ago

I got this to work with named lifetimes. The errors for anonymous lifetimes were really confusing.

phritz commented 3 years ago

Looks like you just need to cargo fmt... (Going afk, one of us will merge soonish, thanks again!)

sayrer commented 3 years ago

I got a bunch of files changed running fmt with cargo 1.52. I'd suggest cribbing this script from Rustls, so the format operation is the same for everyone (and the CI): https://github.com/ctz/rustls/blob/main/admin/fmt

aboodman commented 3 years ago

@phritz for future reference contributors need to sign our CA before we can merge PRs: https://github.com/rocicorp/replicache/blob/main/contributing.md#legal. Should probably add the contributing doc to this repo too, and in the limit a before submit check too.

I reached out to Rob privately and he's signed it so this is good to merge whenever.

aboodman commented 3 years ago

Actually the fmt seems addressed so will merge now.