Closed aboodman closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/rocicorp/replicache-sdk-flutter/fi5flisvu ✅ Preview: https://replicache-sdk-flutter-git-vendoring.rocicorp.now.sh
@arv I made this for the bindings, but it's not working. It makes a lot of changes to sync_replay.json (is that expected?) but more importantly a test fails here:
00:08 +0 -1: sync [E]
Expected: <6>
Actual: <9>
package:test_api expect
package:flutter_test/src/widget_tester.dart 234:3 expect
replicache_test.dart 577:7 main.<fn>
halp?
On the upside your unit test totally caught a compatibility break in repm so whee!
Expected: <6>
Actual: <9>
Looks like it is replaying too much.
The json file changes a lot due to the hashes changing due to the commit contains a date. We might want to consider either having the test server return fake dates or having the test data redact the hashes. It also changes slightly due to the async nature but I think we could "fix" that by introducing some short Future.delayer in a few select places.
Otherwise breaking changes in replicache-client have to be synchronously fixed in bindings which isn't practical.
Related to https://github.com/rocicorp/replicache/issues/60