rocicorp / replicache-sdk-flutter

Replicant SDK for Flutter
https://replicache-sdk-flutter.now.sh/
Other
6 stars 1 forks source link

Miscellaneous fixes found while preparing a release. #86

Closed aboodman closed 4 years ago

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rocicorp/replicache-sdk-flutter/8524jo54o ✅ Preview: https://replicache-sdk-flutter-git-fixes.rocicorp.now.sh

aboodman commented 4 years ago

I'm not sure either. It was required to make flutter run work on my machine. Without it, there were complaints about an unfulfilled http dependency in the http-based invoke implementation. I kinda guessed this was the culprit.

On Tue, Jun 2, 2020 at 5:38 PM Erik Arvidsson notifications@github.com wrote:

@arv commented on this pull request.

In pubspec.yaml https://github.com/rocicorp/replicache-sdk-flutter/pull/86#discussion_r434290047 :

@@ -10,11 +10,11 @@ environment: dependencies: flutter: sdk: flutter

  • http: ^0.12.0+4

[help] I don't understand why this is changed? Is it only for the http status constant?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/rocicorp/replicache-sdk-flutter/pull/86#pullrequestreview-423196751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATUBGK7W6RMISZTXWBR2DRUXAU3ANCNFSM4NRIUTAA .

arv commented 4 years ago

I see now... The file repm_invoker.dart needs to be split into multiple files