Open aboodman opened 1 year ago
@phritz for opinion.
SGTM. An even simpler solution might be to just update the docs to say "... pass replicache.TEST_LICENSE_KEY", but whatever you think is less easy to misuse seems fine. if we go the route of changing its value to "TEST_LICENSE_KEY" then:
Yeah let's change it. Low priority, but a little bit nicer for the env var use case that tslocke describes if the value seems more purposeful. We should also document the value and consider it part of the API going forward.
I think in JS code users will continue to prefer using the constant to avoid "magic number" code smell, but in env vars they can use the string and we will commit to maintaining it.
sgtm
We have one example of a user confusing this:
https://discord.com/channels/830183651022471199/1016346958320902244
... but also making the value of the key part of the API could facilitate using it in env vars and so on.