Closed grgbkr closed 2 years ago
vercel[bot]
commented
2 years ago This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/rocicorp/replicache/8HGtDBuAKQAagxkhQm29DSg5nrXg
✅ Preview: https://replicache-git-grgbkr-brotli-sizes-rocicorp.vercel.app
aboodman
commented
2 years ago Woo!
On Tue, Nov 9, 2021 at 6:59 AM Greg Baker @.***> wrote:
Merged #679 https://github.com/rocicorp/replicache/pull/679 into main.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rocicorp/replicache/pull/679#event-5591248897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATUBHDBDDXMKHARQHZNVTULFHPFANCNFSM5HVWRMNQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- a (phone)
arv
commented
2 years ago LGTM
Problem
Bundle Size dashboard https://rocicorp.github.io/replicache/bundle-sizes/ and associated alerts currently only track non-compressed sizes of bundles. What we really care about is Brotli compressed size.
Solution
Add Brotli compressed sizes of bundles to dashboard and alert. To do this needed to move from
self-hostedrunner toubuntu-latestasbrotlicommand was not available in theself-hostedenvironment (but is inubuntu-latest). This is fine as we don't care about cpu/memory isolation for this benchmark as we do for the performance benchmarks, because we are just measuring byte size.