rocicorp / replicache

Realtime Sync for Any Backend Stack
https://doc.replicache.dev
1.05k stars 37 forks source link

We decided to require `name` correct? #795

Closed aboodman closed 2 years ago

aboodman commented 2 years ago

Right now if you don't provide one the created database name is undefined:

Screen Shot 2022-01-25 at 5 28 44 PM
aboodman commented 2 years ago

I see - we made it required in the typescript type (abf8eccba602014745c95e0b47775b3310eb335a) but there's no runtime checking. I wonder what our policy for this kind of thing should be?

arv commented 2 years ago

This one should probably be a runtime check too.