rocicorp / replicache

Realtime Sync for Any Backend Stack
https://doc.replicache.dev
1.05k stars 37 forks source link

chore: Add a mustGetChunk that throws if missing #866

Closed arv closed 2 years ago

arv commented 2 years ago

Now, all code paths that gets a required chunk uses mustGetChunk. When the chunk is missing this throws a MissingChunkError.

The idea is that the caller will detect these errors and see if the client might have been GC'd.

Towards #784

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rocicorp/replicache/4nKePniFpLJtAGaoEtagcvnsRMkg
✅ Preview: https://replicache-git-arv-must-get-chunk-rocicorp.vercel.app

grgbkr commented 2 years ago

LGTM.