search

rocicorp / replicache

Realtime Sync for Any Backend Stack
https://doc.replicache.dev
1.04k stars 37 forks source link

feat: Add support for pending to makeScanResult #980

Closed arv closed 2 years ago

arv commented 2 years ago

Closes #970

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
replicache ✅ Ready (Inspect) Visit Preview Apr 21, 2022 at 8:04PM (UTC)
arv commented 2 years ago

I think my initial reaction still stands:

Putting this into makeScanResult makes an already hard to understand API even harder to understand.

Having a mergeAsyncIterables function makes sense and it is a bit strange to bundle this with replicache.

arv commented 2 years ago

Changed to draft to ensure not landed. This needs unit tests and JSDoc and maybe even refactoring of the zillion types that this introduces.