rock-core / autoproj-daemon

An Autoproj daemon-plugin that watches github repositories
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

turn autoproj-daemon into a buildbot change source instead of directly triggering builds #40

Closed doudou closed 4 years ago

doudou commented 4 years ago

There are a few important advantages in doing so:

I have now 7 manifests in a single buildconf, managing both the main development build and separate builds for each machine in the system. This change allowed us to decide where to build only mainline, where to build pull request, to ignore pull requests from certain packages we're not interested in ....

It really adds flexibility at the buildbot configuration level, without needing to change autoproj-daemon (which, by nature, is less visible)

g-arjones commented 4 years ago

This is a very good idea, the AnyScheduler thing really is what's supposed to be triggering builds in a buildbot-based CI system. :+1:

If I may, I'm a bit curious about your use case... Usually, the "main development build" is a superset of all other builds (assuming the other "builds" are just different manifests in the same build configuration). What kind of failures are you expecting to catch with this kind of setup?

doudou commented 4 years ago

What kind of failures are you expecting to catch with this kind of setup?

One thing you do catch are bad interactions between the excludes (which avoid building e.g. GUI) and the necessary packages.

But the main driver is to use these builds for CD - generating the artifacts needed to deploy the software.

doudou commented 4 years ago

This is a very good idea, the AnyScheduler thing really is what's supposed to be triggering builds in a buildbot-based CI system. +1

Does this mean this is approved ? :P

g-arjones commented 4 years ago

Yes! Sorry :P