Closed ivan1993br closed 2 years ago
Looks good to me as well. Please, make sure you ran the whole test suite and make sure it passes since you are changing a critical code path.
Yeah... I have just saw that there is one broken test, I am fixing it now
Can you guys approve the workflow run
?
Thanks!
Feature
try_resolve_remote_head_from_server
fromAutobuild::Git
to resolvedefault_branch
Some Points
I use ~
try_resolve_remote_head_from_server
directly from theAutobuild::Git
which will directly requires this API from this importer~resolve_remote_head
, for me, it made sense to use it, we could re-implement a solution here if we do not want to use the importer APII made a "copy-paste" on the test
untar
,no-master
stuff fromAutobuild
, I do not know if it was the best idea, it was the fattest and more reliable that I saw, but you guys see what you think, if I should put in the test helper, use another approach, etc....Take a look and see what it needs to be improved, I am open to any change,
Thanks!