search

rock-core / autoproj

Rock (Robot Construction Kit) package-oriented build system
http://rock-robotics.org/rock-and-syskit/workspace
23 stars 21 forks source link

don't overwrie python shims during install #358

Closed g-arjones closed 2 years ago

g-arjones commented 2 years ago

Fixes #357

I had no idea autoproj would overwrite everything in .autoproj/bin.

doudou commented 2 years ago

I have to admit I forgot about it when I reviewed the PR that creates the stub.

A safer way would be to detect whether the binstub is a ruby script generated by bundler and ignore everything else. They all have a "This file was generated by Bundler" comment, and a she-bang line with ruby in it.

doudou commented 2 years ago

Possibly, just the she-bang line would be enough tbh. This is a controlled folder, anything ruby has been generated by bundler.

g-arjones commented 2 years ago

Done.

caioaamaral commented 2 years ago

Thanks for the fix! @g-arjones