search

rock-core / autoproj

Rock (Robot Construction Kit) package-oriented build system
http://rock-robotics.org/rock-and-syskit/workspace
23 stars 22 forks source link

fix for configuration_option ArgumentError with ruby3 #387

Open vbargsten opened 1 year ago

vbargsten commented 1 year ago

Unsure if this is the intended way, but it works for me on Ubuntu 22.04. Problem is described here: https://rubyreferences.github.io/rubychanges/3.0.html#keyword-arguments-are-now-fully-separated-from-positional-arguments, i.e. number of arguments wrong, 3 given expected 2.

vbargsten commented 11 months ago

That looks indeed more consistent. I don't see a difference. However, it could break callers using a hash as argument (and not **hash transforming it into keyword arguments).

pierrewillenbrockdfki commented 9 months ago

@doudou does this look right? CI seems to be failing due to bundler now hard requiring ruby 3. This seems to work for autoproj status on ubuntu 22.04/ruby 3, ubuntu 20.04/ruby 2.7, ubuntu 18.04/ruby 2.5

chhtz commented 8 months ago

Wouldn't replacing Autoproj.configuration_option by Autoproj.config.declare everywhere also resolve this issue? (I made some PRs for that)