search

rock-core / autoproj

Rock (Robot Construction Kit) package-oriented build system
http://rock-robotics.org/rock-and-syskit/workspace
22 stars 21 forks source link

make .git suffix in repo url optional #400

Closed annaborn closed 2 months ago

annaborn commented 9 months ago

Hello Sylvain @doudou.

Can we make a .git suffix in repo url optional? The repositories in azure devops does not follow the standards, so their repo url does not have .git at the end. We have now a trouble to checkout the azure repos. I mean this line https://github.com/rock-core/autoproj/blob/47e93f159d7053c99e8b6f93139da11b56e695cb/lib/autoproj/git_server_configuration.rb#L103

Does .git suffix required anyway? Since the checkout/push/pull in gitlab and github seems to work also without .git.

We can provide a pull request, just need to know what solution would be accepted. :)

Thank you in advance!

doudou commented 9 months ago

It's a bit meaningless, the best would obviously to just tell everyone to add .git to their URL if they need it, but it's always trick to change existing behavior.

I think the best would be to add a suffix parameter, that would be ".git" by default, and allow nil to disable the feature ?