search

rock-core / base-types

C/C++ and Ruby definition of the base types in Rock
6 stars 40 forks source link

Timezone #144

Closed 2maz closed 4 years ago

2maz commented 4 years ago

You are obviously right regarding the issue being fromString/toString, so updated this branch to address the issue by accounting for offset to UTC information via '%z'.

doudou commented 4 years ago

Hey. Looks for me now.

I suggest we first merge the other PR without the time-related changes, and then this one. This is a big piece of work, I think it'd be best to keep a separate merge/PR commit for it.

If you agree, I can do the rebasing mumbo-jumbo to clean this up.

2maz commented 4 years ago

I suggest we first merge the other PR without the time-related changes, and then this one. This is a big piece of work, I think it'd be best to keep a separate merge/PR commit for it.

Agreed

If you agree, I can do the rebasing mumbo-jumbo to clean this up.

Sure, thanks taking care of this.

doudou commented 4 years ago

OK. I'll get those ready, but wait for the bundler mess fix to get them through CI before I actually merge them.

The fix got merged and the developer who fixed it said he'll try and get a point release out quickly... Fingers crossed.