search

rock-core / base-types

C/C++ and Ruby definition of the base types in Rock
6 stars 40 forks source link

Include BoundingBox and OrientedBoundingBox types #147

Closed gustavoneves12 closed 4 years ago

gustavoneves12 commented 4 years ago

This PR includes two data types to represent axis-aligned and oriented bounding boxes with their uncertainty associated. These two data types could be used on object recognition applications.

gustavoneves12 commented 4 years ago

@doudou I've changed the code following your suggestion. Could you check if everything is correct? Thank you in advance.

gustavoneves12 commented 4 years ago

@doudou I have leveraged this PR and also included a commit which initializes the base::Waypoint with unknown values. Could you please review it?

Thanks in advance

g-arjones commented 4 years ago

@doudou Ping?

doudou commented 4 years ago

@doudou Ping?

Sorry. I've been staying away from GitHub, I have a hard time avoiding that it eats my time. I'll keep a daily schedule looking at stuff from now on.

Sorry again.

gustavoneves12 commented 4 years ago

@gustavoneves12 the change on Waypoint is not backward compatible. This is a rather old type, and there certainly is old code that relies on the current initialization behavior. Please don't include that change here.

@doudou I have changed the waypoint data type to make it backward compatible. In this modification, I have included a new constructor (Waypoint(position, heading = 0) and added the base::unknown<Waypoint>() function to initialize it with unknown values. I think those modifications will not affect existent old codes that rely on this data type.