fix syskit support - Githubissues

doudou commented 4 years ago

These are commits that were exclusively in https://github.com/rock-gazebo/drivers-transformer. It basically fixes the Syskit transformer support, that has been broken circa 2015-2016.

How it happened:

along with Syskit 2 support, I've added SDF load support to the SDF (ca. 2014-2015)
this support was rejected #4
didn't have the time to refactor the complete gazebo/sdf support at the time
lost track of this particular issue, so it never happened.

This is the non-SDF bits. To be honest, even though extracting the whole syskit-sdf support in a separate package is on my todo-list, it's pretty low. So, I am expecting this to happen again.

Obviously, no-one is using Syskit or SDF without going through the Gazebo package set, which overrides this repo with the rock-gazebo fork.

doudou commented 4 years ago

Could you add some documentation for the added methods on lib/transformer.rb

Sure. Done.

2maz commented 4 years ago

Could you add some documentation for the added methods on lib/transformer.rb

Sure. Done.

I think you missed to push the changes

doudou commented 4 years ago

I think you missed to push the changes

I mistakenly pushed them to the rock.gazebo repo ...

rock-core / drivers-transformer

fix syskit support #18